Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: popover target slot width changes according to lsb width change in metricLSB, verification message when adding a user #5239

Conversation

kkdy21
Copy link
Contributor

@kkdy21 kkdy21 commented Dec 17, 2024

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

@kkdy21 kkdy21 requested a review from WANZARGEN December 17, 2024 09:01
@kkdy21 kkdy21 self-assigned this Dec 17, 2024
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:58am
inventory-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:58am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:58am
hotfix2 ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:58am

Signed-off-by: daeyeon ko <[email protected]>
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkdy21 kkdy21 merged commit 71f7dc2 into cloudforet-io:fix/lsb-width_workspace-navigation Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants